On Sat, May 31, 2014 at 09:02:51AM +0900, Michal Nazarewicz wrote: > > On Thu, May 29, 2014 at 05:09:34PM +0900, Gioh Kim wrote: > >> Is IS_ENABLED(CONFIG_CMA) necessary? > >> What about if (migratetype == MIGRATE_MOVABLE && zone->managed_cma_pages) ? > > On Fri, May 30 2014, Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> wrote: > > Yes, field, managed_cma_pages exists only if CONFIG_CMA is enabled, so > > removing IS_ENABLE(CONFIG_CMA) would break the build. > > That statement makes no sense. If zone->managed_cma_pages not being > defined is the problem, what you need is: > > +#ifdef CONFIG_CMA > + if (migratetype == MIGRATE_MOVABLE && zone->managed_cma_pages) > + page = __rmqueue_cma(zone, order); > +#endif > > If you use IS_ENABLED, zone-managed_cma_pages has to be defined > regardless of result of state of CONFIG_CMA. Hello, Oops. I totally misunderstand how IS_ENABLED works. Thanks for spotting this. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>