On Tue 27-05-14 15:53:42, Johannes Weiner wrote:
> On Fri, May 23, 2014 at 03:39:38PM +0200, Michal Hocko wrote:
[...]
> > > if (!PageCgroupUsed(pc))
> > > return;
> > >
> > > - lock_page_cgroup(pc);
> > > - if (PageCgroupUsed(pc)) {
> > > - memcg = pc->mem_cgroup;
> > > - ClearPageCgroupUsed(pc);
> > > - }
> > > - unlock_page_cgroup(pc);
> >
> > maybe add
> > WARN_ON_ONCE(pc->flags != PCG_USED);
> >
> > to check for an unexpected flags usage in the kmem path?
>
> There is no overlap between page types that use PCG_USED and those
> that don't. What would be the value of adding this?
I meant it as an early warning that something bad is going on.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>