On Wed 30-04-14 16:25:42, Johannes Weiner wrote: [...] > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index d3961fce1d54..6f48e292ffe7 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2574,163 +2574,6 @@ static int memcg_cpu_hotplug_callback(struct notifier_block *nb, > return NOTIFY_OK; > } > > -/** > - * mem_cgroup_try_charge - try charging a memcg > - * @memcg: memcg to charge > - * @nr_pages: number of pages to charge > - * @oom: trigger OOM if reclaim fails > - * > - * Returns 0 if @memcg was charged successfully, -EINTR if the charge > - * was bypassed to root_mem_cgroup, and -ENOMEM if the charge failed. > - */ > -static int mem_cgroup_try_charge(struct mem_cgroup *memcg, > - gfp_t gfp_mask, > - unsigned int nr_pages, > - bool oom) Why haven't you simply renamed mem_cgroup_try_charge to try_charge here? The code move is really hard to review. [...] -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>