On Wed, May 07, 2014 at 04:55:53PM +0200, Michal Hocko wrote: > On Wed 30-04-14 16:25:38, Johannes Weiner wrote: > [...] > > @@ -6546,8 +6546,9 @@ one_by_one: > > cond_resched(); > > } > > ret = mem_cgroup_try_charge(memcg, GFP_KERNEL, 1, false); > > + if (ret == -EINTR) > > + __mem_cgroup_cancel_charge(root_mem_cgroup, 1); > > if (ret) > > - /* mem_cgroup_clear_mc() will do uncharge later */ > > I would prefer to keep the comment and explain that we will loose return > code on the way and that is why cancel on root has to be done here. That makes sense, I'll add an explanation of who is (un)charged when and where. Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>