On Wed, May 07, 2014 at 05:13:32PM -0700, Michel Lespinasse wrote: > On Tue, May 6, 2014 at 6:06 AM, Johannes Weiner <hannes@xxxxxxxxxxx> wrote: > > Fixes: 108d6642ad81 ("mm anon rmap: remove anon_vma_moveto_tail") > > I think 108d6642ad81 on its own was OK (as it always took the locks); > but the attempt to not take them in the common case in 38a76013ad80 is > where I forgot to consider the THP case. 108d6642ad81 replaced the chain ordering with an explicit lock, but I see the unconditional locking only in move_ptes(), which isn't called for THP pmds. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>