My bad for introducing the bug, and thanks Kirill for fixing it.
Acked-by: Michel Lespinasse <walken@xxxxxxxxxx>
On Tue, May 6, 2014 at 6:06 AM, Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
> On Tue, May 06, 2014 at 01:13:31AM +0300, Kirill A. Shutemov wrote:
>> But on move_vma() destination VMA can be merged into adjacent one and as
>> result shifted left in interval tree. Fortunately, we can detect the
>> situation and prevent race with rmap walk by moving page table entries
>> under rmap lock. See commit 38a76013ad80.
Yup, forgot to take care of the THP case there...
> Fixes: 108d6642ad81 ("mm anon rmap: remove anon_vma_moveto_tail")
I think 108d6642ad81 on its own was OK (as it always took the locks);
but the attempt to not take them in the common case in 38a76013ad80 is
where I forgot to consider the THP case.
--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>