On Tuesday 29 April 2014 07:48 AM, Rusty Russell wrote: > Madhavan Srinivasan <maddy@xxxxxxxxxxxxxxxxxx> writes: >> diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c >> index 2db8cc6..c87e6b6 100644 >> --- a/arch/powerpc/platforms/pseries/setup.c >> +++ b/arch/powerpc/platforms/pseries/setup.c >> @@ -74,6 +74,8 @@ int CMO_SecPSP = -1; >> unsigned long CMO_PageSize = (ASM_CONST(1) << IOMMU_PAGE_SHIFT_4K); >> EXPORT_SYMBOL(CMO_PageSize); >> >> +extern unsigned int fault_around_order; >> + > > It's considered bad form to do this. Put the declaration in linux/mm.h. > ok. Will change it. Thanks for review With regards Maddy > Thanks, > Rusty. > PS. But we're getting there! :) > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>