On Thu, 2014-04-24 at 07:18 +0200, Michael Kerrisk (man-pages) wrote:
> On 04/23/2014 07:25 AM, Davidlohr Bueso wrote:
> > On Wed, 2014-04-23 at 07:07 +0200, Michael Kerrisk (man-pages) wrote:
> >> On 04/23/2014 04:53 AM, Davidlohr Bueso wrote:
> >>> - Breakup long function names/args.
> >>> - Cleaup variable declaration.
> >>> - s/current->mm/mm
> >>>
> >>> Signed-off-by: Davidlohr Bueso <davidlohr@xxxxxx>
> >>> ---
> >>> ipc/shm.c | 40 +++++++++++++++++-----------------------
> >>> 1 file changed, 17 insertions(+), 23 deletions(-)
> >>>
> >>> diff --git a/ipc/shm.c b/ipc/shm.c
> >>> index f000696..584d02e 100644
> >>> --- a/ipc/shm.c
> >>> +++ b/ipc/shm.c
> >>> @@ -480,15 +480,13 @@ static const struct vm_operations_struct shm_vm_ops = {
> >>> static int newseg(struct ipc_namespace *ns, struct ipc_params *params)
> >>> {
> >>> key_t key = params->key;
> >>> - int shmflg = params->flg;
> >>> + int id, error, shmflg = params->flg;
> >>
> >> It's largely a matter of taste (and I may be in a minority), and I know
> >> there's certainly precedent in the kernel code, but I don't much like the
> >> style of mixing variable declarations that have initializers, with other
> >> unrelated declarations (e.g., variables without initializers). What is
> >> the gain? One less line of text? That's (IMO) more than offset by the
> >> small loss of readability.
> >
> > Yes, it's taste. And yes, your in the minority, at least in many core
> > kernel components and ipc.
>
> Davidlohr,
>
> So, noting that the minority is less small than we thought, I'll just
> add this: I'd have appreciated it if your reply had been less
> dismissive, and you'd actually responded to my concrete point about
> loss of readability.
Apologies, I didn't mean to sound dismissive. It's just that I don't
like arguing over this kind of things. The idea of the cleanups wasn't
"lets remove LoC", but more "lets make the style suck less" -- and
believe me, ipc code is pretty darn ugly wrt. Over the last few months
we've improved it some, but still so much horror. The changes I make are
aligned with the general coding style we have in the rest of the kernel,
but yes, ultimately it comes down to taste.
Anyway, I am in favor of single line declarations with initializers
which are *meaningful*. The variables I moved around are not.
Thanks,
Davidlohr
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>