On Fri, Apr 18, 2014 at 02:03:09PM -0400, Johannes Weiner wrote:
> On Fri, Apr 18, 2014 at 03:50:33PM +0100, Mel Gorman wrote:
> > @@ -2463,7 +2462,7 @@ static inline struct page *
> > __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order,
> > struct zonelist *zonelist, enum zone_type high_zoneidx,
> > nodemask_t *nodemask, struct zone *preferred_zone,
> > - int migratetype)
> > + int classzone_idx, int migratetype)
> > {
> > const gfp_t wait = gfp_mask & __GFP_WAIT;
> > struct page *page = NULL;
>
> There is another potential update of preferred_zone in this function
> after which the classzone_idx should probably be refreshed:
>
> /*
> * Find the true preferred zone if the allocation is unconstrained by
> * cpusets.
> */
> if (!(alloc_flags & ALLOC_CPUSET) && !nodemask)
> first_zones_zonelist(zonelist, high_zoneidx, NULL,
> &preferred_zone);
Thanks, I'll fix it up for v2.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>