On 04/18/2014 11:39 AM, Jianyu Zhan wrote: > Hi, Christoph Hellwig, > >> There are no modular users of lru_cache_add, so please don't needlessly >> export it. > > yep, I re-checked and found there is no module user of neither > lru_cache_add() nor lru_cache_add_anon(), so don't export it. > > Here is the renewed patch: > --- > > In mm/swap.c, __lru_cache_add() is exported, but actually there are > no users outside this file. However, lru_cache_add() is supposed to > be used by vfs, or whatever others, but it is not exported. > > This patch unexports __lru_cache_add(), and makes it static. > It also exports lru_cache_add_file(), as it is use by cifs, which > be loaded as module. > > Signed-off-by: Jianyu Zhan <nasa4836@xxxxxxxxx> Acked-by: Rik van Riel <riel@xxxxxxxxxx> -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>