On 4/16/2014 12:57 AM, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 2db08cc65391d73dc8cbcaefdb55c42a774d9e1a > commit: ff35bd54456e18878c361a8a2deeb41c9688458f [103/113] lib/scatterlist: make ARCH_HAS_SG_CHAIN an actual Kconfig > config: make ARCH=powerpc ppc6xx_defconfig > > All error/warnings: > > arch/powerpc/platforms/52xx/efika.c: In function 'efika_probe': >>> arch/powerpc/platforms/52xx/efika.c:210:2: error: 'ISA_DMA_THRESHOLD' undeclared (first use in this function) > ISA_DMA_THRESHOLD = ~0L; > ^ > arch/powerpc/platforms/52xx/efika.c:210:2: note: each undeclared identifier is reported only once for each function it appears in >>> arch/powerpc/platforms/52xx/efika.c:211:2: error: 'DMA_MODE_READ' undeclared (first use in this function) > DMA_MODE_READ = 0x44; > ^ >>> arch/powerpc/platforms/52xx/efika.c:212:2: error: 'DMA_MODE_WRITE' undeclared (first use in this function) > DMA_MODE_WRITE = 0x48; > ^ Another fixup needed (should cover errors from other generated config as well) ---- 8< ---- >From 0da362c18c93da425e1e3c5b364d12ff49a46d8f Mon Sep 17 00:00:00 2001 From: Laura Abbott <lauraa@xxxxxxxxxxxxxx> Date: Wed, 16 Apr 2014 09:20:55 -0700 Subject: [PATCH] powerpc: Include asm/dma.h explicitly commit ff35bd54456e18878c361a8a2deeb41c9688458f (lib/scatterlist: make ARCH_HAS_SG_CHAIN an actual Kconfig) changed powerpc to use the generic scatterlist.h. The powerpc scatterlist.h header was including asm/dma.h as well so removing the include broke a few things: arch/powerpc/platforms/52xx/efika.c: In function 'efika_probe': arch/powerpc/platforms/52xx/efika.c:210:2: error: 'ISA_DMA_THRESHOLD' undeclared arch/powerpc/platforms/52xx/efika.c:211:2: error: 'DMA_MODE_READ' undeclared arch/powerpc/platforms/52xx/efika.c:212:2: error: 'DMA_MODE_WRITE' undeclared Explicitly include asm/dma.h where necessary. Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx> Cc: kbuild test robot <fengguang.wu@xxxxxxxxx> Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> Signed-off-by: Laura Abbott <lauraa@xxxxxxxxxxxxxx> --- arch/powerpc/platforms/52xx/efika.c | 1 + arch/powerpc/platforms/amigaone/setup.c | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/powerpc/platforms/52xx/efika.c b/arch/powerpc/platforms/52xx/efika.c index 18c1048..47d6679 100644 --- a/arch/powerpc/platforms/52xx/efika.c +++ b/arch/powerpc/platforms/52xx/efika.c @@ -13,6 +13,7 @@ #include <generated/utsrelease.h> #include <linux/pci.h> #include <linux/of.h> +#include <asm/dma.h> #include <asm/prom.h> #include <asm/time.h> #include <asm/machdep.h> diff --git a/arch/powerpc/platforms/amigaone/setup.c b/arch/powerpc/platforms/amigaone/setup.c index 03aabc0..2fe1204 100644 --- a/arch/powerpc/platforms/amigaone/setup.c +++ b/arch/powerpc/platforms/amigaone/setup.c @@ -24,6 +24,7 @@ #include <asm/i8259.h> #include <asm/time.h> #include <asm/udbg.h> +#include <asm/dma.h> extern void __flush_disable_L1(void); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>