On Thu, Apr 03 2014 at 09:33:15 AM, Christoph Lameter <cl@xxxxxxxxx> wrote: > On Mon, 31 Mar 2014, Joe Perches wrote: > >> On Mon, 2014-03-31 at 13:35 -0500, Christoph Lameter wrote: >> > On Thu, 27 Mar 2014, Mitchel Humpherys wrote: >> > >> > > diff --git a/mm/slub.c b/mm/slub.c >> [] >> > > @@ -9,6 +9,8 @@ >> > > * (C) 2011 Linux Foundation, Christoph Lameter >> > > */ >> > > >> > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt >> > >> > This is implicitly used by some macros? If so then please define this >> > elsewhere. I do not see any use in slub.c of this one. >> >> Hi Christoph >> >> All the pr_<level> macros use it. >> >> from include/linux/printk.h: > > Ok then why do you add the definition to slub.c? Ah that was an oversight on my part after changing to pr_cont. I'll send a v3 that removes the pr_fmt. Or I could send a v3 that leaves the pr_fmt but changes the printk that the pr_cont's are continuing (at the top of note_cmpxchg_failure) to pr_info, but that wouldn't be consistent with the rest of the file, which is using hand-tagged printk's. I don't know if it's worthwhile to convert all of the hand-tagged printk's to the pr_ macros, but if so I can do that in a separate patch. -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>