Hi! On Fri 2014-01-31 02:46:08, David Rientjes wrote: > On Fri, 31 Jan 2014, Pavel Machek wrote: > > > > kstrimdup will duplicate and trim spaces from the passed in > > > null terminated string. This is useful for strings coming from > > > sysfs that often include trailing whitespace due to user input. > > > > Is it good idea? I mean "\n\n/foo bar baz" is valid filename in > > unix. This is kernel interface, it is not meant to be too user > > friendly... > > v6 of this patchset carries your ack of the patch that uses this for > /sys/debug/resume, so are you disagreeing we need this support at > all or /sys/power/resume, no? > that it shouldn't be the generic sysfs write behavior? If the latter, I > agree, and the changelog could be improved to specify what writes we > actually care about. Well, your /sys/power/resume patch would be nice cleanup, but it changs behaviour, too... which is unnice. Stripping trailing "\n" is probably neccessary, because we did it before. (It probably was a mistake). But kernel is not right place to second-guess what the user meant. Just return -EINVAL. This is kernel ABI, after all, not user facing shell. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>