* Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx> wrote: > > > For the time being, I'll just remove the EXPORT. If people feel > > > that inline is the right way to go, then we'll leave the > > > function in mcs_spin_lock.h and not create mcs_spin_lock.c. > > > > Well, 'people' could be you, the person touching the code? This is > > really something that is discoverable: look at the critical path > > in the inlined and the out of line case, and compare the number of > > instructions. This can be done based on disassembly of the > > affected code. > > Okay, will make it inline function and drop the move of to > mcs_spin_lock.c Only if I'm right! I was speculating. Thanks, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>