On Mon, Jan 20, 2014 at 05:24:31PM -0800, Tim Chen wrote: > +EXPORT_SYMBOL_GPL(mcs_spin_lock); > +EXPORT_SYMBOL_GPL(mcs_spin_unlock); Do we really need the EXPORTs? The only user so far is mutex and that's core code. The other planned users are rwsems and rwlocks, for both it would be in the slow path, which is also core code. We should generally only add EXPORTs once theres a need. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>