If the definition of the get_allocated_memblock_reserved_regions_info() function when CONFIG_ARCH_DISCARD_MEMBLOCK simply returns 0, the compiler will see that size is defined, the optimizer will see that it is always 0 and that the if(0) is always false. The net result will be no code will be produced and the function will be less cluttered. On Thu, Jan 16, 2014 at 11:41 AM, Philipp Hachtmann <phacht@xxxxxxxxxxxxxxxxxx> wrote: > >> I would think you would be better off making >> get_allocated_memblock_reserved_regions_info() and >> get_allocated_memblock_memory_regions_info be static inline functions >> when #ifdef CONFIG_ARCH_DISCARD_MEMBLOCK. > Possible, of course. > But the size variable has still to be #ifdef'd. And that's what the > patch is about. It's just an addition to another patch. > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>