Re: [PATCH] mm/nobootmem: Fix unused variable

[Robin Holt <robinmholt@xxxxxxxxx>]

I can not see how this works.  How is the return from get_allocated_memblock_reserved_regions_info() stored and used without being declared?  Maybe you are working off a different repo than Linus' latest?  Your line 116 is my 114.  Maybe the message needs to be a bit more descriptive and certain the bit after the '---' should be telling me what this is applying against.

Robin

On Thu, Jan 16, 2014 at 7:33 AM, Philipp Hachtmann <phacht@xxxxxxxxxxxxxxxxxx> wrote:

This fixes an unused variable warning in nobootmem.c

Signed-off-by: Philipp Hachtmann <phacht@xxxxxxxxxxxxxxxxxx>
---
 mm/nobootmem.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/mm/nobootmem.c b/mm/nobootmem.c
index e2906a5..12cbb04 100644
--- a/mm/nobootmem.c
+++ b/mm/nobootmem.c
@@ -116,9 +116,13 @@ static unsigned long __init __free_memory_core(phys_addr_t start,
 static unsigned long __init free_low_memory_core_early(void)
 {
        unsigned long count = 0;
-       phys_addr_t start, end, size;
+       phys_addr_t start, end;
        u64 i;

+#ifdef CONFIG_ARCH_DISCARD_MEMBLOCK
+       phys_addr_t size;
+#endif
+
        for_each_free_mem_range(i, NUMA_NO_NODE, &start, &end, NULL)
                count += __free_memory_core(start, end);

--
1.8.4.5