On Tue, 14 Jan 2014, Dave Hansen wrote: > >> page->pfmemalloc does not deserve a spot in 'struct page'. It is > >> only used transiently _just_ after a page leaves the buddy > >> allocator. > > > > Why would we need to do this if we are removing the cmpxchg_double? > > Why do we need the patch? > > 'struct page' is a mess. It's really hard to follow, and the space in > the definition is a limited resource. We should not waste that space on > such a transient and unimportant value as pfmemalloc. > I don't have any strong opinions on whether this patch is merged or not, but I'm not sure it's cleaner to do it with an accessor function that overloads page->index when its placement within the union inside struct page makes that obvious, nor is it good that the patch adds more code than it removes solely because it introduces those accessor functions. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>