Hi Mel, On Wed, Dec 11, 2013 at 09:14:22AM +0000, Mel Gorman wrote: >On Wed, Dec 11, 2013 at 08:50:00AM +0800, Wanpeng Li wrote: >> Adjust numa_scan_period in task_numa_placement, depending on how much useful >> work the numa code can do. The local faults and remote faults should be used >> to check if there is record hinting faults instead of local faults and shared >> faults. This patch fix it. >> >> Reviewed-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx> >> Signed-off-by: Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx> > >This potentially has the side-effect of making it easier to reduce the >scan rate because it'll only take the most recent scan window into >account. The existing code takes recent shared accesses into account. The local/remote and share/private both accumulate the just finished scan window, why takes the most recent scan window into account will reduce the scan rate than takes recent shared accesses into account? >What sort of tests did you do on this patch and what was the result? I find this by codes review, I can drop this patch if your point is correct. ;-) Regards, Wanpeng Li > >-- >Mel Gorman >SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>