On Wed, Dec 11, 2013 at 09:21:23AM +0000, Mel Gorman wrote: >On Wed, Dec 11, 2013 at 08:50:01AM +0800, Wanpeng Li wrote: >> Drop unnecessary total_faults variable in function task_weight to unify >> task_weight and group_weight. >> >> Reviewed-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx> >> Signed-off-by: Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx> > >Nak. > >task_weight is called for tasks other than current. If p handles a fault >in parallel then it can drop to 0 between when it's checked and used to >divide resulting in an oops. I see, thanks for your pointing out. Regards, Wanpeng Li > >-- >Mel Gorman >SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>