On Mon, Dec 09, 2013 at 06:10:46PM +0900, Joonsoo Kim wrote:
>update_pageblock_skip() only fits to compaction which tries to isolate by
>pageblock unit. If isolate_migratepages_range() is called by CMA, it try to
>isolate regardless of pageblock unit and it don't reference
>get_pageblock_skip() by ignore_skip_hint. We should also respect it on
>update_pageblock_skip() to prevent from setting the wrong information.
>
>Cc: <stable@xxxxxxxxxxxxxxx> # 3.7+
>Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
>Reviewed-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>
>Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
Reviewed-by: Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx>
>
>diff --git a/mm/compaction.c b/mm/compaction.c
>index 805165b..f58bcd0 100644
>--- a/mm/compaction.c
>+++ b/mm/compaction.c
>@@ -134,6 +134,10 @@ static void update_pageblock_skip(struct compact_control *cc,
> bool migrate_scanner)
> {
> struct zone *zone = cc->zone;
>+
>+ if (cc->ignore_skip_hint)
>+ return;
>+
> if (!page)
> return;
>
>--
>1.7.9.5
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@xxxxxxxxx. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>