Re: [PATCH v2 6/7] mm/migrate: remove unused function, fail_migrate_page()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 09, 2013 at 06:10:47PM +0900, Joonsoo Kim wrote:
>fail_migrate_page() isn't used anywhere, so remove it.
>
>Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
>

Reviewed-by: Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx>

>diff --git a/include/linux/migrate.h b/include/linux/migrate.h
>index e4671f9..4308018 100644
>--- a/include/linux/migrate.h
>+++ b/include/linux/migrate.h
>@@ -41,9 +41,6 @@ extern int migrate_page(struct address_space *,
> extern int migrate_pages(struct list_head *l, new_page_t x,
> 		unsigned long private, enum migrate_mode mode, int reason);
>
>-extern int fail_migrate_page(struct address_space *,
>-			struct page *, struct page *);
>-
> extern int migrate_prep(void);
> extern int migrate_prep_local(void);
> extern int migrate_vmas(struct mm_struct *mm,
>@@ -83,7 +80,6 @@ static inline int migrate_huge_page_move_mapping(struct address_space *mapping,
>
> /* Possible settings for the migrate_page() method in address_operations */
> #define migrate_page NULL
>-#define fail_migrate_page NULL
>
> #endif /* CONFIG_MIGRATION */
>
>diff --git a/mm/migrate.c b/mm/migrate.c
>index cdafdc0..b595f89 100644
>--- a/mm/migrate.c
>+++ b/mm/migrate.c
>@@ -550,14 +550,6 @@ void migrate_page_copy(struct page *newpage, struct page *page)
>  *                    Migration functions
>  ***********************************************************/
>
>-/* Always fail migration. Used for mappings that are not movable */
>-int fail_migrate_page(struct address_space *mapping,
>-			struct page *newpage, struct page *page)
>-{
>-	return -EIO;
>-}
>-EXPORT_SYMBOL(fail_migrate_page);
>-
> /*
>  * Common logic to directly migrate a single page suitable for
>  * pages that do not use PagePrivate/PagePrivate2.
>-- 
>1.7.9.5
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]