Hi,
Thank you for the review. I agree with all your comments and I'll resend
the fixed version soon.
If anyone still has something to say about the patchset, I'd be glad to
hear from them.
On 11/25/2013 09:41 PM, Johannes Weiner wrote:
I ran out of steam reviewing these because there were too many things
that should be changed in the first couple patches.
I realize this is frustrating to see these type of complaints in v11
of a patch series, but the review bandwidth was simply exceeded back
when Glauber submitted this along with the kmem accounting patches. A
lot of the kmemcg commits themselves don't even have review tags or
acks, but it all got merged anyway, and the author has moved on to
different projects...
Too much stuff slips past the only two people that have more than one
usecase on their agenda and are willing to maintain this code base -
which is in desparate need of rework and pushback against even more
drive-by feature dumps. I have repeatedly asked to split the memcg
tree out of the memory tree to better deal with the vastly different
developmental stages of memcg and the rest of the mm code, to no
avail. So I don't know what to do anymore, but this is not working.
Thoughts?
That's a pity, because w/o this patchset kmemcg is in fact useless.
Perhaps, it's worth trying to split it? (not sure if it'll help much
though since first 11 patches are rather essential :-( )
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>