On Fri, 2013-10-11 at 10:23 +0800, Weijie Yang wrote: > I am sorry to interrupt this topic, but I found an tiny issue near that: > > we can not "set_blocksize(bdev, p->old_block_size);" at the end of swapoff() > because swap_info p may be reused by concurrent swapon called > I think we need to save the p->old_block_size in a local var and use it instead I confirm the race here (I was able to trigger it on the same swap type). > to Krzysztof : would you please add this in your patch? > Thanks I think it should be another patch as this is not related with frontswap. I'll send new one and add you as Reported-by. Is it OK with you? Best regards, Krzysztof -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>