On Thu, Oct 10, 2013 at 09:29:07AM +0800, Bob Liu wrote: > On 10/09/2013 10:40 PM, Seth Jennings wrote: > > > > The reason we never noticed this for zswap is that zswap has no > > dynamically allocated per-type resources. In the expected case, > > where all of the pages have been drained from zswap, > > zswap_frontswap_invalidate_area() is a no-op. > > > > Not exactly, see the bug fix "mm/zswap: bugfix: memory leak when > re-swapon" from Weijie. > Zswap needs invalidate_area() also. I remembered this patch as soon as I sent out this note. What I said about zswap_frontswap_invalidate_area() being a no-op in the expected case is true as of v3.12-rc4, but it shouldn't be :) I sent a note to Andrew reminding him to pull in that patch. Thanks, Seth -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>