On Wed, 2 Oct 2013 13:17:45 -0700 Davidlohr Bueso <davidlohr@xxxxxx> wrote:
> Various parts of the kernel acquire and release this mutex,
> so add i_mmap_lock_write() and immap_unlock_write() helper
> functions that will encapsulate this logic. The next patch
> will make use of these.
>
> ...
>
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -478,6 +478,16 @@ struct block_device {
>
> int mapping_tagged(struct address_space *mapping, int tag);
>
> +static inline void i_mmap_lock_write(struct address_space *mapping)
> +{
> + mutex_lock(&mapping->i_mmap_mutex);
> +}
I don't understand the thinking behind the "_write". There is no
"_read" and all callsites use "_write", so why not call it
i_mmap_lock()?
I *assume* the answer is "so we can later convert some sites to a new
i_mmap_lock_read()". If so, the changelog should have discussed this.
If not, still confused.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>