On Fri, Sep 20, 2013 at 01:31:51PM +0100, Mel Gorman wrote: > @@ -1402,14 +1394,15 @@ unlock: > if (!join) > return; > > + double_lock(&my_grp->lock, &grp->lock); > + > for (i = 0; i < 2*nr_node_ids; i++) { > - atomic_long_sub(p->numa_faults[i], &my_grp->faults[i]); > - atomic_long_add(p->numa_faults[i], &grp->faults[i]); > + my_grp->faults[i] -= p->numa_faults[i]; > + grp->faults[i] -= p->numa_faults[i]; > + WARN_ON_ONCE(grp->faults[i] < 0); > } That stupidity got fixed -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>