On Fri, Sep 20, 2013 at 01:31:52PM +0100, Mel Gorman wrote: > static inline unsigned long group_weight(struct task_struct *p, int nid) > { > + if (!p->numa_group || !p->numa_group->total_faults) > return 0; > > + return 1200 * group_faults(p, nid) / p->numa_group->total_faults; > } Unrelated to this change; I recently thought we might want to change these weight factors based on if the task was predominantly private or shared. For shared we use the bigger weight for group, for private we use the bigger weight for task. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>