Hi Yinghai, On Wed, Aug 28, 2013 at 07:42:29PM -0700, Yinghai Lu wrote: >On Wed, Aug 28, 2013 at 7:34 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote: >> On Wed, Aug 28, 2013 at 7:18 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote: >>> please change to function pointer to >>> void (*alloc_func)(void *data, >>> unsigned long pnum_begin, >>> unsigned long pnum_end, >>> unsigned long map_count, int nodeid) >>> >>> pnum_begin, pnum_end, map_coun, nodeid, should not be in the struct. >> >> looks like that is what is your first version did. >> >> I updated it a little bit. please check it. >> > >removed more lines. Thanks for your great work! The fixed patch looks good to me. If this is the last fix and I can ignore http://marc.info/?l=linux-mm&m=137774271220239&w=2? Regards, Wanpeng Li > >Yinghai -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>