On Tue, Aug 20, 2013 at 4:07 PM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, 20 Aug 2013 14:54:54 +0800 Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx> wrote:
>
>> v1 -> v2:
>> * add comments to describe alloc_usemap_and_memmap
>>
>> After commit 9bdac91424075("sparsemem: Put mem map for one node together."),
>> vmemmap for one node will be allocated together, its logic is similar as
>> memory allocation for pageblock flags. This patch introduce alloc_usemap_and_memmap
>> to extract the same logic of memory alloction for pageblock flags and vmemmap.
>>
>
> 9bdac91424075 was written by Yinghai. He is an excellent reviewer, as
> long as people remember to cc him!
could be that he forgot to use scripts/get_maintainer.pl
or get_maintainer.pl has some problem.
>
>> ---
>> mm/sparse.c | 140 ++++++++++++++++++++++++++++--------------------------------
>> 1 file changed, 66 insertions(+), 74 deletions(-)
>>
>> diff --git a/mm/sparse.c b/mm/sparse.c
>> index 308d503..d27db9b 100644
>> --- a/mm/sparse.c
>> +++ b/mm/sparse.c
>> @@ -439,6 +439,14 @@ static void __init sparse_early_mem_maps_alloc_node(struct page **map_map,
>> map_count, nodeid);
>> }
>> #else
>> +
>> +static void __init sparse_early_mem_maps_alloc_node(struct page **map_map,
>> + unsigned long pnum_begin,
>> + unsigned long pnum_end,
>> + unsigned long map_count, int nodeid)
>> +{
>> +}
>> +
...
could be avoided, if passing function pointer instead.
>> static struct page __init *sparse_early_mem_map_alloc(unsigned long pnum)
>> {
>> struct page *map;
>> @@ -460,6 +468,62 @@ void __attribute__((weak)) __meminit vmemmap_populate_print_last(void)
>> {
>> }
>>
>> +/**
>> + * alloc_usemap_and_memmap - memory alloction for pageblock flags and vmemmap
>> + * @map: usemap_map for pageblock flags or mmap_map for vmemmap
>> + * @use_map: true if memory allocated for pageblock flags, otherwise false
>> + */
>> +static void alloc_usemap_and_memmap(unsigned long **map, bool use_map)
...
>> @@ -471,11 +535,7 @@ void __init sparse_init(void)
>> unsigned long *usemap;
>> unsigned long **usemap_map;
>> int size;
...
>> - /* ok, last chunk */
>> - sparse_early_usemaps_alloc_node(usemap_map, pnum_begin, NR_MEM_SECTIONS,
>> - usemap_count, nodeid_begin);
>> + alloc_usemap_and_memmap(usemap_map, true);
alloc_usemap_and_memmap() is somehow confusing.
Please check if you can pass function pointer instead of true/false.
Thanks
Yinghai
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>