On 08/21/2013 07:16 AM, Andrew Morton wrote: > On Tue, 20 Aug 2013 11:31:52 +0800 Chen Gang <gang.chen@xxxxxxxxxxx> wrote: > >> force_page_cache_readahead() may fail, so need let the related upper >> system calls know about it by its return value. >> >> Also let related code pass "scripts/checkpatch.pl's" checking. >> >> --- a/mm/fadvise.c >> +++ b/mm/fadvise.c >> @@ -107,8 +107,8 @@ SYSCALL_DEFINE4(fadvise64_64, int, fd, loff_t, offset, loff_t, len, int, advice) >> * Ignore return value because fadvise() shall return >> * success even if filesystem can't retrieve a hint, >> */ > > ^^ look. > Oh, thanks. It is my fault, I will send patch v2 for it. >> - force_page_cache_readahead(mapping, f.file, start_index, >> - nrpages); >> + ret = force_page_cache_readahead(mapping, f.file, start_index, >> + nrpages); >> break; > > > Thanks. -- Chen Gang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>