Re: [PATCH] mm: readahead: return the value which force_page_cache_readahead() returns

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 20 Aug 2013 11:31:52 +0800 Chen Gang <gang.chen@xxxxxxxxxxx> wrote:

> force_page_cache_readahead() may fail, so need let the related upper
> system calls know about it by its return value.
> 
> Also let related code pass "scripts/checkpatch.pl's" checking.
> 
> --- a/mm/fadvise.c
> +++ b/mm/fadvise.c
> @@ -107,8 +107,8 @@ SYSCALL_DEFINE4(fadvise64_64, int, fd, loff_t, offset, loff_t, len, int, advice)
>  		 * Ignore return value because fadvise() shall return
>  		 * success even if filesystem can't retrieve a hint,
>  		 */

		^^ look.

> -		force_page_cache_readahead(mapping, f.file, start_index,
> -					   nrpages);
> +		ret = force_page_cache_readahead(mapping, f.file, start_index,
> +						 nrpages);
>  		break;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]