Khalid Aziz wrote: > On Sun, 2013-08-04 at 05:17 +0300, Kirill A. Shutemov wrote: > > From: "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx> > > > > We are not ready to mmap file-backed tranparent huge pages. Let's split > > them on fault attempt. > > > > Later we'll implement mmap() properly and this code path be used for > > fallback cases. > > > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx> > > --- > > mm/filemap.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/mm/filemap.c b/mm/filemap.c > > index ed65af5..f7857ef 100644 > > --- a/mm/filemap.c > > +++ b/mm/filemap.c > > @@ -1743,6 +1743,8 @@ retry_find: > > goto no_cached_page; > > } > > > > + if (PageTransCompound(page)) > > + split_huge_page(compound_trans_head(page)); > > Since PageTransCompound(page) returns true for transparent huge pages as > well as hugetlbfs pages, could this code split hugetlbfs pages on an > mmap() on to hugetlbfs pages? hugetlbfs pages are not supposed to be > split, right? hugetlbfs page cannot (should not) be here. hugetlb uses different vm_ops->fault handeler. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>