On 07/12/2013 09:58 PM, Christoph Lameter wrote: > On Fri, 12 Jul 2013, Chen Gang wrote: > >> Be sure of 80 column limitation for both code and comments. >> Correct tab alignment for 'if-else' statement. > > Thanks. > Thank you too. >> Remove redundancy 'break' statement. > > Hmm... I'd rather have the first break removed. > Yeah, that will be better for coding and understanding. I will send patch v2 for it. >> Remove useless BUG_ON(), since it can never happen. > > It may happen if more code is added to that function. Recently the cgroups > thing was added f.e. > Hmm... at least what you said is reasonable. I need respect the related maintainers' willing and opinions (e.g. you for "slub.c"). > Could you separate this out into multiple patches that each do one thing > only? > OK, thanks. I will do. Originally, I think these are minor, I should do with them in a patch, so can save maintainers' time resource (now, I know it is incorrect). :-) Thanks. -- Chen Gang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>