Re: [PATCH] mm/slub.c: beautify code of this file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 12 Jul 2013, Chen Gang wrote:

> Be sure of 80 column limitation for both code and comments.
> Correct tab alignment for 'if-else' statement.

Thanks.

> Remove redundancy 'break' statement.

Hmm... I'd rather have the first break removed.

> Remove useless BUG_ON(), since it can never happen.

It may happen if more code is added to that function. Recently the cgroups
thing was added f.e.

Could you separate this out into multiple patches that each do one thing
only?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]