On Fri, Jun 21, 2013 at 07:37:25AM +0800, Wanpeng Li wrote: > On Thu, Jun 20, 2013 at 09:46:15PM +0800, Fengguang Wu wrote: > >> fs/fs-writeback.c | 10 ++-------- > >> 1 files changed, 2 insertions(+), 8 deletions(-) > > > >The header file should be changed, too. Otherwise looks fine to me. > > > >include/linux/writeback.h:97:long wb_do_writeback(struct bdi_writeback *wb, int force_wait); > > Thanks for your review, Fengguang. ;-) > > The line in header file has already been removed by commit(836f29bbb0: > fs/fs-writeback.c: : make wb_do_writeback() as static) in -next tree > since there is just one caller in fs/fs-writeback.c. Ah OK. I was reading the upstream kernel.. However it still presents a tricky situation (for Andrew Morton) that commit 836f29bbb0 MUST be merged before your patch in the next merge window. Otherwise it will lead to a range of build failure commits. Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>