On Thu, Jun 13, 2013 at 09:02:58PM +0800, Tang Chen wrote: > From: Yinghai Lu <yinghai@xxxxxxxxxx> > > In order to seperate parsing numa info procedure into two steps, > we need to set memblock nid later, as it could change memblock > array, and possible doube memblock.memory array which will need > to allocate buffer. > > We do not need to use nid in memblock to find out absent pages. because... And please also explain it in the source code with comment including why the check has to be done early. > So we can move that numa_meminfo_cover_memory() early. Maybe "So, we can use the NUMA-unaware absent_pages_in_range() in numa_meminfo_cover_memory() and call the function before setting nid's to memblock." > Also we could change __absent_pages_in_range() to static and use > absent_pages_in_range() directly. "As this removes the last user of __absent_pages_in_range(), this patch also makes the function static." Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>