Hello, Does the subject match the patch content? What two functions? The patch is separating out the actual registration part so that the discovery part can happen earlier, right? > Currently, parsing numa info needs to allocate some buffer and need to be > called after init_mem_mapping. So try to split parsing numa info procedure > into two steps: > - The first step will be called before init_mem_mapping, and it > should not need allocate buffers. Document the requirement somewhere in the source code? > - The second step will cantain all the buffer related code and be > executed later. > > At last we will have early_initmem_init() and initmem_init(). Do you mean "eventually" or "in the end" by "at last"? > This patch implements only the first step. > > setup_node_data() and numa_init_array() are only called for successful > path, so we can move these two callings to x86_numa_init(). That will also > make numa_init() smaller and more readable. I find the description somewhat difficult to follow. :( > -v2: remove online_node_map clear in numa_init(), as it is only > set in setup_node_data() at last in successful path. I don't get this. What prevents specific numa init functions (numaq, x86_acpi, amd...) from updating node_online_map? Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>