On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote: > +static inline unsigned long mapping_align_mask(struct address_space *mapping) > +{ > + if (mapping_can_have_hugepages(mapping)) > + return PAGE_MASK & ~HPAGE_MASK; > + return get_align_mask(); > +} get_align_mask() appears to be a bit more complicated to me than just a plain old mask. Are you sure you don't need to pick up any of its behavior for the mapping_can_have_hugepages() case? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>