On Thu, May 16, 2013 at 07:55:23PM +0530, Aneesh Kumar K.V wrote: > Andrea Arcangeli <aarcange@xxxxxxxxxx> writes: > > > Hi Aneesh, > > > > On Mon, May 13, 2013 at 08:36:38PM +0530, Aneesh Kumar K.V wrote: > >> https://lists.ozlabs.org/pipermail/linuxppc-dev/2013-May/106406.html > > > > You need ACCESS_ONCE() in all "pgd = ACCESS_ONCE(*pgdp)", "pud = > > ACCESS_ONCE(*pudp)" otherwise the compiler could decide your change is > > a noop. > > Will do. I guess we have similar one for x86 here Exactly. > > http://article.gmane.org/gmane.linux.kernel/1483617 > > May be ppc64 gup walk also need similar changes ? I think so, yes. > > I think you could remove the #ifdef CONFIG_TRANSPARENT_HUGEPAGE too. > > That was becaue i had pte_pmd available only with that config. I will > see if we can fix that. Ok, up to you. Thanks, Andrea -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>