Re: [PATCH 06/10] mm: vmscan: Have kswapd writeback pages based on dirty pages encountered, not priority

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/17/2013 11:11 AM, Mel Gorman wrote:
On Sun, Mar 17, 2013 at 07:42:39AM -0700, Andi Kleen wrote:
Mel Gorman <mgorman@xxxxxxx> writes:

@@ -495,6 +495,9 @@ typedef enum {
  	ZONE_CONGESTED,			/* zone has many dirty pages backed by
  					 * a congested BDI
  					 */
+	ZONE_DIRTY,			/* reclaim scanning has recently found
+					 * many dirty file pages
+					 */

Needs a better name. ZONE_DIRTY_CONGESTED ?


That might be confusing. The underlying BDI is not necessarily
congested. I accept your point though and will try thinking of a better
name.

ZONE_LOTS_DIRTY ?

+	 * currently being written then flag that kswapd should start
+	 * writing back pages.
+	 */
+	if (global_reclaim(sc) && nr_dirty &&
+			nr_dirty >= (nr_taken >> (DEF_PRIORITY - sc->priority)))
+		zone_set_flag(zone, ZONE_DIRTY);
+
  	trace_mm_vmscan_lru_shrink_inactive(zone->zone_pgdat->node_id,

I suppose you want to trace the dirty case here too.


I guess it wouldn't hurt to have a new tracepoint for when the flag gets
set. A vmstat might be helpful as well.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]