On Wed, Mar 20, 2013 at 09:03:20AM +0800, Simon Jeons wrote: > Hi Naoya, > On 02/22/2013 03:41 AM, Naoya Horiguchi wrote: > >Currently we can't offline memory blocks which contain hugepages because > >a hugepage is considered as an unmovable page. But now with this patch > >series, a hugepage has become movable, so by using hugepage migration we > >can offline such memory blocks. > > > >What's different from other users of hugepage migration is that we need > >to decompose all the hugepages inside the target memory block into free > > For other hugepage migration users, hugepage should be freed to > hugepage_freelists after migration, but why I don't see any codes do > this? The source hugepages which are migrated by NUMA related system calls (migrate_pages(2), move_pages(2), and mbind(2)) are still useable, so we simply free them into free hugepage pool. OTOH, the source hugepages migrated by memory hotremove should not be reusable, because users of memory hotremove want to remove the memory from the system. So we need to free such hugepages forcibly into the buddy pages, otherwise memory offining doesn't work. Thanks, Naoya -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>