Paul Mackerras <paulus@xxxxxxxxx> writes: > On Thu, Feb 21, 2013 at 10:17:10PM +0530, Aneesh Kumar K.V wrote: >> From: "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx> >> >> USE PTRS_PER_PTE to indicate the size of pte page. >> >> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxxxxxxx> >> powerpc: Don't hard code the size of pte page >> >> USE PTRS_PER_PTE to indicate the size of pte page. >> >> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxxxxxxx> > > Description and signoff are duplicated. Description could be more > informative, for example - why would we want to do this? > >> +/* >> + * hidx is in the second half of the page table. We use the >> + * 8 bytes per each pte entry. > > The casual reader probably wouldn't know what "hidx" is. The comment > needs at least to use a better name than "hidx". how about +/* + * We save the slot number & secondary bit in the second half of the + * PTE page. We use the 8 bytes per each pte entry. + */ -aneesh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>