Hello Naoya
[add Michal in cc list]
On Fri, Feb 22, 2013 at 3:41 AM, Naoya Horiguchi
<n-horiguchi@xxxxxxxxxxxxx> wrote:
>
> +/* Returns true for head pages of in-use hugepages, otherwise returns false. */
> +int is_hugepage_movable(struct page *hpage)
s/int/bool/ can we?
> +{
> + struct page *page;
> + struct page *tmp;
> + struct hstate *h = page_hstate(hpage);
Make sense to compute hstate for a tail page?
> + int ret = 0;
> +
> + VM_BUG_ON(!PageHuge(hpage));
> + if (PageTail(hpage))
> + return 0;
VM_BUG_ON(!PageHuge(hpage) || PageTail(hpage)), can we?
> + spin_lock(&hugetlb_lock);
> + list_for_each_entry_safe(page, tmp, &h->hugepage_activelist, lru)
s/_safe// can we?
> + if (page == hpage)
> + ret = 1;
Can we bail out with ret set to be true?
> + spin_unlock(&hugetlb_lock);
> + return ret;
> +}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>