Hi,
The addition of this BUG_ON should make debugging easier.
While I understand that this code path is "hot", surely
it is better to assert the condition than to wait until
some random NULL pointer dereference or page fault. If the
caller passes an invalid nodeid, at this stage in my opinion
it's already a BUG.
Cheers,
Aaron
---8<---
mm: slab: Verify the nodeid passed to ____cache_alloc_node
If the nodeid is > num_online_nodes() this can cause an
Oops and a panic(). The purpose of this patch is to assert
if this condition is true to aid debugging efforts rather
than some random NULL pointer dereference or page fault.
Signed-off-by: Aaron Tomlin <atomlin@xxxxxxxxxx>
slab.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/slab.c b/mm/slab.c
index e7667a3..735e8bd 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -3412,6 +3412,7 @@ static void *____cache_alloc_node(struct kmem_cache *cachep, gfp_t flags,
void *obj;
int x;
+ BUG_ON(nodeid > num_online_nodes());
l3 = cachep->nodelists[nodeid];
BUG_ON(!l3);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>