On Wed, 06 Feb 2013 09:34:16 +0800 Zhang Yanfei <zhangyanfei@xxxxxxxxxxxxxx> wrote:
> >
> >
> > hm,
> >
> > static unsigned int nr_free_zone_pages(int offset)
> > {
> > ...
> > unsigned int sum = 0;
> > ...
> > return sum;
> > }
> >
> > How long will it be until these things start exploding from
> > sums-of-zones which exceed 16TB?
> >
>
> You mean overflow? Hmm.. it might happens. Change the sum to
> unsigned long is ok?
The sum, the return value. And in the case of nr_free_buffer_pages(),
the signedness of the return value (sheesh). Then review and if
necessary fix up all the callsites. That's all a separate exercise.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>