于 2013年02月06日 09:20, Andrew Morton 写道:
> On Wed, 06 Feb 2013 09:06:05 +0800
> Zhang Yanfei <zhangyanfei@xxxxxxxxxxxxxx> wrote:
>
>> So could I rename the functions to the names like
>> nr_available_buffer_high_pages
>> And accurately document them with code comments just as you suggested.
>
> gee. "available" implies "available for you to allocate". It has the
> same problem as "free".
>
> And "buffer" shouldn't be there - that's a reflection of the fact
> that buffer_head payloads are not allocated from highmem. An archaic
> irrelevant thing.
>
> Seriously, first let's write down the descriptions of what these
> functions *do*. Then choose nice names which abbreviate that.
>
OK, I will try to do this.
>
>
> hm,
>
> static unsigned int nr_free_zone_pages(int offset)
> {
> ...
> unsigned int sum = 0;
> ...
> return sum;
> }
>
> How long will it be until these things start exploding from
> sums-of-zones which exceed 16TB?
>
You mean overflow? Hmm.. it might happens. Change the sum to
unsigned long is ok?
Thanks
Zhang Yanfei
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href