On Wed, 12 Dec 2012, Kirill A. Shutemov wrote: > > What's the benefit from doing this other than generalizing some per-arch > > code? It simply adds on more layer of redirection to try to find the > > implementation that matters for the architecture you're hacking on. > > The idea of asm-generic is consolidation arch code which can be re-used > for different arches. It also makes support of new arches easier. > Yeah, but you're moving is_zero_pfn() unnecessarily into a header file when it is only used mm/memory.c and it adds a __HAVE_* definition that we always try to reduce (both __HAVE and __ARCH definitions are frowned upon). I don't think it's much of a win to obfuscate the code because mips and s390 implement colored zero pages. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>