On Mon, Nov 19, 2012 at 02:06:48AM -0800, Hugh Dickins wrote: > On Mon, 19 Nov 2012, Shaohua Li wrote: > > > > Changes from V1 to V2: > > 1. free cluster is added to a list, which makes searching cluster more efficient > > 2. only enable the buddy allocator for SSD. > > Oh. My fault, not yours at all, but I wish I'd known this was coming. > I spent today testing and fixing (a couple of hangs in discard 2/2) V1, > was about to send you a patch, but looks like none of it relevant to V2. Appologize for this. I was in travel last whole week, a little lagged to fully test the V2 patch till yesterday. Had no confidence to bother again before I know it really works. > It's nice work you've done, I thoroughly approve of V1 (very minor mods), > but it'll take me a few more days to get around to looking at V2, sorry. > > Though, it may be my ignorance, I entirely fail to see what this has to > do with a buddy allocator: you've speeded up scan_swap_map()'s search > for a cluster by adding an additional cluster map, then extended that > neatly for a much better discard implementation. Good work yes, but > a buddy allocator?? That is just the name I called. I thought it's a variant of buddy allocator, don't take it serious. Thanks, Shaohua -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>