On Tue, Feb 25, 2025 at 10:01 PM Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx> wrote: > > On Tue, Feb 25, 2025 at 04:17:01PM -0800, Jeff Xu wrote: > > On Tue, Feb 25, 2025 at 2:32 AM Lorenzo Stoakes > > <lorenzo.stoakes@xxxxxxxxxx> wrote: > > > > > > BTW can we please drop the 'mseal, system mappings' prefixes on this > > > series, it's really weird and makes it really hard for me to actually read > > > the individual summary lines for each commit. 'mseal:' will do. > > > > > > > I am not sure. > > I had comments about adding mseal, system mappings, as prefixes, and I > > think it is reasonable. > > No it's really horrible (sorry I know it's hyperbolic but it really really looks > horrid to me) , I've never seen prefixes like that before in mm in my life and I > don't think it adds anything. > > I also find it MIGHTY confusing. > > Please remove this :) you can git log the relevant files to see the conventions > people use. Typically xxx: has something really short and sweet for the 'xxx'. > > I realise this is subjective, but it's a small thing and would be helpful for > parsing your series at a glance. > I need a prefix to group the patches, especially when the first patch is just a config change. "mseal" won't work because this patch isn't about core business logic of mseal. How about "mseal sysmap:"? -Jeff
